fix(auth): Remove online check from getCurrentUser #3122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjroach
approved these changes
Sep 3, 2025
harsh62
approved these changes
Sep 3, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3122 +/- ##
==========================================
- Coverage 54.27% 54.25% -0.02%
==========================================
Files 1038 1038
Lines 31991 32006 +15
Branches 4700 4703 +3
==========================================
+ Hits 17363 17365 +2
- Misses 12788 12802 +14
+ Partials 1840 1839 -1 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3118
Description of changes:
Removes the check for expired refresh tokens from the
getCurrentUsercall. None of the other Amplify platforms had this check, so this better aligns with their implementations.Now
getCurrentUserwill be a simple offline-only check to see if there are cached credentials on the device. If there are, we return the user data.This does mean that in cases where you were signed in but your refresh tokens have expired (or were revoked)
getCurrentUserwill now succeed, where previously it would have failed.How did you test these changes?
getCurrentUserstill succeeds.Documentation update required?
General Checklist
fix(storage): message,feat(auth): message,chore(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.